Migrate version tab to vue #26675
Migrate version tab to vue #26675
Conversation
| import './css/versions.css' | ||
| import './versionmodel'; | ||
| import './versioncollection'; | ||
| import './versionstabview'; |
There was a problem hiding this comment.
You can remove this since you're now providing your own tab.
But for the development phase, you can leave it so you will have 2 versions tab and you will be more at ease when comparing the two :)
There was a problem hiding this comment.
I ll leave it for the development phase
| --> | ||
|
|
||
| <template> | ||
| <li class="version-entry"> |
| this.version.fullPath = fullPath | ||
| this.version.fileId = fileId | ||
| this.version.name = name | ||
| this.version.timestamp = parseInt(moment(new Date(version.timestamp)).format('X'), 10) | ||
| this.version.id = OC.basename(version.href) | ||
| this.version.size = parseInt(version.size, 10) | ||
| this.version.user = user | ||
| this.version.client = client |
There was a problem hiding this comment.
What is this.version? It does not seems to be declared anyhere.
I assume there is some code missing or this is still a WIP? 🤔 😉
There was a problem hiding this comment.
removed and updated in FileVersion Service
| const fetchVersion = await axios.get(shareUrl, { | ||
| params: { | ||
| format, | ||
| path, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Are you not using the davClient service(s)?
skjnldsv
added
2. developing
|
|
||
| <template> | ||
| <ListItemIcon class="version-entry" | ||
| icon="icon-text" |
There was a problem hiding this comment.
The icon needs to be the mime type.
You can get it with the method: OC.MimeType.getIconUrl(mimetype).
It will return an url of the icon (to be used like the Avatar component: https://github.com/nextcloud/nextcloud-vue/blob/8d1dca2df1e7ee02b50b8b52355f801e6799220a/src/components/ListItemIcon/ListItemIcon.vue#L65)
e.g. OC.MimeType.getIconUrl('image/jpg')
| {{ version.timestamp }}Restore | ||
| </ActionButton> | ||
| <ActionButton icon="icon-delete" @click="alert('Delete')"> | ||
| Download |
| subtitle="< 1KB"> | ||
| <Actions> | ||
| <ActionButton icon="icon-edit" @click="alert('Edit')"> | ||
| {{ version.timestamp }}Restore |
| if (OCA.Files && OCA.Files.Sidebar) { | ||
| OCA.Files.Sidebar.registerTab(new OCA.Files.Sidebar.Tab({ | ||
| id: 'versions', | ||
| name: t('files_versions', 'version'), |
| details: true, | ||
| }, options)) | ||
|
|
||
| return response.data.map(FileVersion) |
| import Videos from '../models/videos' | ||
| import Audios from '../models/audios' | ||
|
|
||
| export default class Viewer { |
There was a problem hiding this comment.
Its removed, it was just for reference
| fileInfo: null, | ||
| currentUser: null, |
| setCurrentUser(user) { | ||
| this._currentUser = user | ||
| }, |
| <IfModule pagespeed_module> | ||
| ModPagespeed Off | ||
| </IfModule> | ||
| #### DO NOT CHANGE ANYTHING ABOVE THIS LINE #### |
There was a problem hiding this comment.
This change come from your development setup with a specific configuration, so please do not commit that
| const path = (this.fileInfo.path + '/' + this.fileInfo.name).replace('//', '/') | ||
| // Fetch Version | ||
| const fetchVersion = await axios.get(shareUrl, { | ||
| const fetchFileVersions = await axios.get(shareUrl, { |
There was a problem hiding this comment.
This should not be needed as the request would need to be issued by the below call to the webdav client in order to get the list of versions with the following propfind request for example:
| import { translate as t, translatePlural as n } from '@nextcloud/l10n' | ||
|
|
||
| import VersionTab from '../../files_versions/src/views/VersionTab' | ||
| import TabSections from '../../files_versions/src/services/TabSections' |
There was a problem hiding this comment.
What would this be about? There is not tab section service yet ;)
| console.log(error); | ||
| } | ||
| } | ||
| mounted() { |
There was a problem hiding this comment.
mounted is not expected to be within the methods but at the root of the vue component object.
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Ref #20020